Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Score anchor flow #136

Merged
merged 15 commits into from
Oct 26, 2023
Merged

Conversation

adi-a11y
Copy link
Contributor

@adi-a11y adi-a11y commented Oct 17, 2023

This PR is a draft and is created to gather reviews for the score anchor flow.

Let's consider that "demo/utils/updateScore" as a marketplace. Within this marketplace, the "fromJournalContent" function in "Scoring.ts" is invoked. The result produced by this function will be employed by the marketplace to trigger the "makeScoreEntryToChain" function in "Scoring.chain.ts."

@adi-a11y adi-a11y requested a review from amarts October 24, 2023 12:00
…n-submit tx to happen outside to chain, change journal entry array signing method
@amarts amarts changed the base branch from develop to dev-0.9.0 October 26, 2023 11:22
@amarts
Copy link
Member

amarts commented Oct 26, 2023

Looking fine for now. Lets merge and make another work on it. (Merging it on dev-0.9.0 branch)

@amarts amarts merged commit 710ea55 into dhiway:dev-0.9.0 Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants