Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

CREATE new list #185

Merged
merged 23 commits into from
Mar 22, 2018
Merged

CREATE new list #185

merged 23 commits into from
Mar 22, 2018

Conversation

sofiag
Copy link
Contributor

@sofiag sofiag commented Mar 6, 2018

CREATE new list component and add it to the framework-for-listings and form-dialog components to activate new list form dialog

…d form-dialog components to activate new list form dialog
@sofiag sofiag added this to the admin 1.0.0 milestone Mar 6, 2018
@sofiag sofiag self-assigned this Mar 6, 2018
@sofiag sofiag closed this Mar 14, 2018
@sofiag sofiag reopened this Mar 14, 2018
@sofiag
Copy link
Contributor Author

sofiag commented Mar 15, 2018

This should be complete now, I created one form (list-form) for editing list info and creating new list. The services for create new list and editing lists need to be created still @subotic, while there are some issues with the service for updating list Info, dealt with in issue #209.
If this looks ok, I would like to merge.

Copy link
Member

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we really have to start at some point, we might as well do it now.

Could you please try and create a rudimentary test for the component?

https://angular.io/guide/testing#component-test-scenarios

@subotic
Copy link
Member

subotic commented Mar 15, 2018

also, the tests on Travis are failing

@sofiag
Copy link
Contributor Author

sofiag commented Mar 15, 2018

Damn, I thought I had fixed the problems with the tests...

@sofiag
Copy link
Contributor Author

sofiag commented Mar 16, 2018

@subotic I will look into it. They should all go in the spec.ts file right?

@sofiag
Copy link
Contributor Author

sofiag commented Mar 16, 2018

@subotic @kilchenmann I am not sure how to implement extra tests correctly and I don't want to mess up this PR while the current test are passing. Besides, I need to work on implementing list and node edit only for administrator user. My plan was to work on that after this PR. Can we merge this now, and we can look at the tests together when I'm in the office? (I am on home office due to the move but can drop by whenever you have time).

@sofiag
Copy link
Contributor Author

sofiag commented Mar 21, 2018

@subotic Can I merge?

@subotic
Copy link
Member

subotic commented Mar 21, 2018

sorry, yes.

@sofiag
Copy link
Contributor Author

sofiag commented Mar 22, 2018

@subotic @kilchenmann Have you changed the permissions of the repository? I am not able/allowed to merge my PR!!:

screen shot 2018-03-22 at 08 58 21

@subotic
Copy link
Member

subotic commented Mar 22, 2018

can you try now?

@sofiag
Copy link
Contributor Author

sofiag commented Mar 22, 2018

No, still not...

@subotic
Copy link
Member

subotic commented Mar 22, 2018

maybe now?

@sofiag
Copy link
Contributor Author

sofiag commented Mar 22, 2018

no... weird...

@subotic
Copy link
Member

subotic commented Mar 22, 2018

now it should work.

@sofiag
Copy link
Contributor Author

sofiag commented Mar 22, 2018

yes! what was the problem?

@subotic
Copy link
Member

subotic commented Mar 22, 2018

I changed the settings :-)

@sofiag
Copy link
Contributor Author

sofiag commented Mar 22, 2018

thx!

@sofiag sofiag merged commit afa04d4 into develop Mar 22, 2018
@sofiag sofiag deleted the wip/create-new-list-#28 branch March 22, 2018 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants