-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
…d form-dialog components to activate new list form dialog
…oblem in createList service, WIP
…sel/Salsah into wip/create-new-list-#28
…/ REMOVE depricated new-list component
This should be complete now, I created one form (list-form) for editing list info and creating new list. The services for create new list and editing lists need to be created still @subotic, while there are some issues with the service for updating list Info, dealt with in issue #209. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we really have to start at some point, we might as well do it now.
Could you please try and create a rudimentary test for the component?
also, the tests on Travis are failing |
Damn, I thought I had fixed the problems with the tests... |
@subotic I will look into it. They should all go in the spec.ts file right? |
@subotic @kilchenmann I am not sure how to implement extra tests correctly and I don't want to mess up this PR while the current test are passing. Besides, I need to work on implementing list and node edit only for administrator user. My plan was to work on that after this PR. Can we merge this now, and we can look at the tests together when I'm in the office? (I am on home office due to the move but can drop by whenever you have time). |
@subotic Can I merge? |
sorry, yes. |
@subotic @kilchenmann Have you changed the permissions of the repository? I am not able/allowed to merge my PR!!: |
can you try now? |
No, still not... |
maybe now? |
no... weird... |
now it should work. |
yes! what was the problem? |
I changed the settings :-) |
thx! |
CREATE new list component and add it to the framework-for-listings and form-dialog components to activate new list form dialog