Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Fixes for build in production mode #212

Merged
merged 5 commits into from
Mar 16, 2018
Merged

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Mar 14, 2018

This PR fixes some issues we had when building SALSAH in production mode

This PR does not solve the build problem in JDNConvertibleDateAdapter: dhlab-basel/JDNConvertibleCalendarDateAdapter#5

relates to #198

@tobiasschweizer tobiasschweizer self-assigned this Mar 14, 2018
@tobiasschweizer tobiasschweizer changed the title refactor (get rid of constructor.name) Fixes for build in production mode Mar 15, 2018
@tobiasschweizer
Copy link
Contributor Author

@subotic Is this PR ready for review?

@subotic
Copy link
Member

subotic commented Mar 15, 2018

yes, http://beol.dasch.swiss runs of this branch already.

Copy link
Member

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :-)

@tobiasschweizer
Copy link
Contributor Author

@kilchenmann Do you also want to look at this?

Copy link
Member

@kilchenmann kilchenmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@tobiasschweizer tobiasschweizer merged commit 3610b0b into develop Mar 16, 2018
@tobiasschweizer tobiasschweizer deleted the wip/fix-prod-build branch March 16, 2018 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants