Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

feature (app): add app config #260

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feature (app): add app config #260

wants to merge 7 commits into from

Conversation

subotic
Copy link
Member

@subotic subotic commented Jun 5, 2018

Summary

  • add application config at runtime
  • move constants to app.constants.ts
  • document basic configuration

Issues

@subotic subotic self-assigned this Jun 5, 2018
@subotic subotic added this to the v2.0.0-alpha.15 milestone Jun 5, 2018
@subotic
Copy link
Member Author

subotic commented Jun 11, 2018

@kilchenmann this works now but only without AgularFireModule. To be able to work with the AngularFireModule, we need to provide the AngularFireModule config by using DI as provided in 5.0.0-rc.9 (needs angular 6): https://github.com/angular/angularfire2/releases/tag/5.0.0-rc.9. Is there a timetable regarding the upgrade to Angular 6?

@kilchenmann
Copy link
Member

The AngularFireModule is needed by the Beol beta release.
We're still working on the schedule. The whole process of updating Salsah to Angular 6 depends on the new core module which includes the services. I hope this is done by the end of June.

@subotic
Copy link
Member Author

subotic commented Jun 11, 2018

The AngularFireModule is needed by the Beol beta release.

Yes, I know. That's why this cannot be merged and Angular 6 is needed.

@kilchenmann kilchenmann changed the base branch from develop to master September 11, 2018 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editable Config Files
3 participants