Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGB LED (WS2812B) and 62/60 support #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edfan
Copy link

@edfan edfan commented May 8, 2016

Adds RGB LED support.

The process is fairly convoluted, but works decently well. Since setting RGB values in the GUI is tedious (there isn't a good way to select multiple keys at once), the task is delegated to keyboard-layout-editor instead. After some setup in the board file (described in RGB_README.md), a configurator like this one can be used. The raw data is then imported into EasyAVR and parsed.

Current limitations: 160 RGB LEDs (due to power draw, no board is likely to hit this number ever), solid colors only (no effects), only port C is guaranteed to work, and KLE is required.

Additionally, support for the 62/60 keyboard is added, including RGB configuration.

edfan added 2 commits May 8, 2016 16:32
Added RGB LED support.  The scheme is described in RGB_README.md.

Current limitations: 160 LEDs maximum (easily editable), no effects,
requires KLE for configuration.
@dhowland
Copy link
Owner

dhowland commented May 9, 2016

Wow, this is a lot of stuff. Does it work?

@edfan
Copy link
Author

edfan commented May 9, 2016

Yep- works perfectly on my 62/60 boards. Every LED is correct and brightness is limited correctly (which means current is limited).

@edfan
Copy link
Author

edfan commented May 10, 2016

Programmed this board with my fork today.

@edfan
Copy link
Author

edfan commented May 23, 2016

Any updates on this? I'd be willing to distribute this separately if you could help me out with py2exe.

@dhowland
Copy link
Owner

Yeah, uhh.... I've been away from this project for a while because DOOM came out last week. Sorry, I will get to this.

@edfan
Copy link
Author

edfan commented Jun 26, 2016

Hate to bring this up again, but it's been a very long time. If you don't have time to review the commit, I'm willing to package & distribute this fork myself.

@roadna
Copy link

roadna commented Nov 18, 2016

A wonderful feature of RGB lighting!

@dhowland
Copy link
Owner

dhowland commented Feb 4, 2017

trying to work through all the pull requests lately

@neolectron
Copy link

beep boop, any up ?

@dhowland
Copy link
Owner

This patch, as it exists now, appears to be insufficient for general inclusion in the project. It looks great for your particular board, however the port and pin (C7) is permanently configured in ws2812_config.h and this could not be changed with the keymapper tool for other boards that do not use this pin.

@dhowland
Copy link
Owner

Okay, I see, it's not restricted to C7 for all applications, just PORTC like you said. I wonder if there is a way around that, though.

@dkave
Copy link

dkave commented Sep 5, 2017

guys not to be weird about it - but is this going to happen or is this diamond not going to be cut?

@edfan
Copy link
Author

edfan commented Sep 5, 2017

The project is dead at this point, so I'm okay with keeping this as a fork. @dhowland can do whatever he wants.

@dkave
Copy link

dkave commented Sep 5, 2017

@edfan - sorry to hear that man
@dhowland - why are we not doing this?

@dhowland
Copy link
Owner

dhowland commented Sep 5, 2017

@dkave I already commented on this patch (see above, Feb 12th). This project covers many different boards with varying hardware. Anything in the firmware itself must be made general-purpose. This patch isn't. I kept the pull request open in case @edfan wanted to continue to work the code. It appears he does not.

You can still use his fork for the 62/60 support.

@dkave
Copy link

dkave commented Sep 5, 2017

@edfan + @dhowland i understand your point and would do it but cant code worth a %^&*
too bad guys - would have been a very cool addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants