Choices: Add override for custom choice buttons #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The choice buttons for the
Centered ChoicesandTextbubble Layerlayers can be replaced with aPackedScenedescending fromDialogicNode_ChoiceButton. This is intended for users who want custom behavior for their buttons (the choice must be pressed 3 times, on-hover animations, multi-ControlUI, etc.).New Settings:
Centered Choices:
Text/Behavior/Custom ButtonTextbubble Layer:
Choices/Behavior/Custom ButtonChanges to
DialogicNode_ChoiceButton:The on-pressed behavior of the button can be customized by overriding
_on_pressed(). By default, this preserves the existing behavior by emitting the newchoice_selectedsignal when the button is pressed. The Choices Subsystem has now listens for the button'schoice_selectedsignal instead ofpressed.Changes to VN/Centered Choice Layer:
The centered choice layer now instantiates its buttons when the style is changed (functionally similar to Textbubble Layer) so that custom buttons are applied, including while the timeline is running.