Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gamepad scroll descriptions to match logic in plrctrls #7764

Merged

Conversation

StephenCWills
Copy link
Member

Updates the logic for gamepad scroll descriptions in PrintItemMisc() to match the logic in CtrlUseInvItem().

Based on the following snippet in CtrlUseInvTime(), scrolls that target monsters are not usable from the inventory. All other scrolls should be usable.

Item &item = GetInventoryItem(myPlayer, pcursinvitem);
if (item.isScroll()) {
if (TargetsMonster(item._iSpell)) {
return;

This resolves #7761

@AJenbo AJenbo enabled auto-merge (rebase) February 18, 2025 05:31
@AJenbo AJenbo merged commit 8f2154f into diasurgical:master Feb 18, 2025
23 checks passed
@StephenCWills StephenCWills deleted the gamepad-targeting-scroll-descriptions branch February 18, 2025 05:36
@AJenbo
Copy link
Member

AJenbo commented Feb 18, 2025

also backported to 1.5 just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue Report]: Scrolls description
2 participants