Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change repository structure #206

Closed
wants to merge 5 commits into from

Conversation

nck-mlcnv
Copy link
Contributor

This pull request merges all maven modules to just one. The pom.xml file has also been changed accordinlgy.

@nck-mlcnv nck-mlcnv requested a review from bigerl May 12, 2023 15:31
@nck-mlcnv nck-mlcnv linked an issue May 12, 2023 that may be closed by this pull request
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the packages is fine for now. Build is successful on my system.
The structure of the packages is still not optimal but that can be tackled later.
On the high level I would for example write out cc and rp.

…sitory-structure

# Conflicts:
#	iguana.commons/pom.xml
#	iguana.corecontroller/pom.xml
#	iguana.resultprocessor/pom.xml
#	src/main/java/org/aksw/iguana/cc/utils/IndexedQueryReader.java
#	src/test/java/org/aksw/iguana/cc/utils/IndexedQueryReaderTest.java
#	src/test/resources/readLineTestFile1.txt
#	src/test/resources/readLineTestFile2.txt
#	src/test/resources/readLineTestFile3.txt
#	src/test/resources/utils/indexingtestfile1.txt
#	src/test/resources/utils/indexingtestfile2.txt
#	src/test/resources/utils/indexingtestfile3.txt
#	src/test/resources/utils/indexingtestfile4.txt
#	src/test/resources/utils/indexingtestfile5.txt
@bigerl
Copy link
Member

bigerl commented Jun 29, 2023

#215 super-seeded this PR. closing it.

@bigerl bigerl closed this Jun 29, 2023
@bigerl bigerl deleted the fix/issue-189/repository-structure branch June 29, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository structure review
2 participants