Rework result processing #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 6, 2023
Closed
Closed
- metrics should also now be created before the storages
Closed
bigerl
requested changes
Jul 12, 2023
src/main/java/org/aksw/iguana/cc/tasks/stresstest/storage/impl/CSVStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/tasks/stresstest/storage/impl/CSVStorage.java
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/tasks/stresstest/storage/impl/CSVStorage.java
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/tasks/stresstest/storage/impl/CSVStorage.java
Show resolved
Hide resolved
bigerl
approved these changes
Aug 7, 2023
| @@ -184,19 +175,9 @@ protected HttpContext getAuthContext(String endpoint) { | |||
| } | |||
|
|
|||
| public synchronized void addResults(QueryExecutionStats results) { | |||
| // TODO: check if statement for bugs, if the if line exists in the UpdateWorker, the UpdateWorker fails its tests | |||
There was a problem hiding this comment.
This one can be ignored for now because the UpdateWorker will be rewritten anyway.
|
|
||
| Model m = ModelFactory.createDefaultModel(); | ||
|
|
||
| m.add(experimentRes, RDF.type, IONT.experiment); |
| this.suiteFolder = folder.resolve(IguanaConfig.getSuiteID()); | ||
| } | ||
|
|
||
| public static Arguments createTestData1() { |
There was a problem hiding this comment.
The data generation of this test is highly fragile in a sense that small changes to the rdf serialization render the generated data incorrec.t. It could be more robust if it relied on StresstestResultProcessor directly to generate a jena model.
This applies in a similar fashion to the other tests in this package as well. This doesn't need to be patched but can be moved to an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainy aims to renew the result processing as it was quite messy. Changes: