Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check for username length #618

Closed
wants to merge 3 commits into from
Closed

Added a check for username length #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15a0787
Added max username length to auth/register route
keirim Oct 4, 2024
813fcab
Fixed register
keirim Oct 4, 2024
cc24427
Fixed register route for api
keirim Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions src/pages/api/auth/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { jsonUserReplacer } from 'lib/utils/client';
import { extname } from 'path';

const logger = Logger.get('user');
const MAX_USERNAME_LENGTH = 12;

async function handler(req: NextApiReq, res: NextApiRes) {
const user = await req.user();
Expand All @@ -26,34 +27,32 @@ async function handler(req: NextApiReq, res: NextApiRes) {
code?: string;
};

if (!username) badRequest = true;
if (!password) badRequest = true;
if (!username || !password) return res.badRequest('Bad Username/Password');

// Validate username length
if (username.length > MAX_USERNAME_LENGTH) {
return res.badRequest(`Username cannot exceed ${MAX_USERNAME_LENGTH} characters`);
}

const existing = await prisma.user.findFirst({
where: {
username,
},
select: {
username: true,
},
where: { username },
select: { username: true },
});

if (existing) badRequest = true;

if (badRequest) return res.badRequest('Bad Username/Password');
if (existing) return res.badRequest('Bad Username/Password');

if (code) {
if (config.features.invites) {
const invite = await prisma.invite.findUnique({
where: {
code,
},
where: { code },
});

if (!invite || invite?.used) return res.badRequest('Bad invite');
usedInvite = true;
} else return res.badRequest('Bad Username/Password');
} else if (config.features.invites && !user?.administrator) return res.badRequest('Bad invite');
} else if (config.features.invites && !user?.administrator) {
return res.badRequest('Bad invite');
}

const hashed = await hashPassword(password);

Expand Down Expand Up @@ -85,7 +84,7 @@ async function handler(req: NextApiReq, res: NextApiRes) {
});

logger.debug(
`registered user${usedInvite ? ' via invite ' + code : ''} ${JSON.stringify(newUser, jsonUserReplacer)}`,
`registered user${usedInvite ? ' via invite ' + code : ''} ${JSON.stringify(newUser, jsonUserReplacer)}`
);

delete newUser.password;
Expand Down
16 changes: 15 additions & 1 deletion src/pages/auth/register.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export default function Register({ code = undefined, title, user_registration })
const [verifyPasswordError, setVerifyPasswordError] = useState('');
const [strength, setStrength] = useState(0);

const MAX_USERNAME_LENGTH = 16;

const setUser = useSetRecoilState(userSelector);
const router = useRouter();

Expand All @@ -30,6 +32,11 @@ export default function Register({ code = undefined, title, user_registration })
const checkUsername = async () => {
setUsername(username.trim());

if (username.length > MAX_USERNAME_LENGTH) {
setUsernameError(`Username cannot exceed ${MAX_USERNAME_LENGTH} characters`);
return;
}

setUsernameError('');

const res = await useFetch('/api/user/check', 'POST', { code, username });
Expand Down Expand Up @@ -101,7 +108,14 @@ export default function Register({ code = undefined, title, user_registration })
<TextInput
label='Username'
value={username}
onChange={(e) => setUsername(e.target.value)}
onChange={(e) => {
setUsername(e.target.value);
if (e.target.value.length > MAX_USERNAME_LENGTH) {
setUsernameError(`Username cannot exceed ${MAX_USERNAME_LENGTH} characters`);
} else {
setUsernameError('');
}
}}
error={usernameError}
onBlur={() => checkUsername()}
/>
Expand Down
Loading