Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proper range request handling #635

Merged
merged 8 commits into from
Dec 5, 2024
Merged

feat: proper range request handling #635

merged 8 commits into from
Dec 5, 2024

Conversation

ari-party
Copy link
Contributor

@ari-party ari-party commented Dec 1, 2024

This pull request is a follow up on #576.

Changes:

  • Datasource get() support for byte ranges (local datasource tested, s3 follows docs, supabase unsure as not in docs, please test supabase!)
  • Datasource size() now returns null if a file wasn't found or there was an error (0 byte files are still files)
  • Proper range request handling and responses (above change is now used to see if a file exists or not)

Minor changes:

  • Change @types/node version to 18
  • Fix Dockerfile casing warnings

Please reply if you have questions or comments!

@diced diced merged commit c0b2dda into diced:trunk Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants