Fix injecting argument to the command #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Injection of the
-P
flag into the command to be run would only work if theargs
value was an empty string.exec_path="foo.exe"
andargs=""
resulting intofoo.exe -P bar.py
was workingexec_path="foo.exe"
andargs="baz"
resulting intofoo.exe baz-P bar.py
was broken(expected result is
foo.exe baz -P bar.py
, note additionnal whitespace)By the way, adding a blank space at the end of the arguments string in SG does not work because whitespaces get trimmed.
Solution
Simply add a whitespace before the
-P
argument (like with tk-harmony's-debug
flag)