Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix injecting argument to the command #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aboellinger
Copy link

@aboellinger aboellinger commented Mar 7, 2022

Problem

Injection of the -P flag into the command to be run would only work if the args value was an empty string.

  • exec_path="foo.exe" and args="" resulting into foo.exe -P bar.py was working
  • exec_path="foo.exe" and args="baz" resulting into foo.exe baz-P bar.py was broken
    (expected result is foo.exe baz -P bar.py , note additionnal whitespace)

By the way, adding a blank space at the end of the arguments string in SG does not work because whitespaces get trimmed.

Solution

Simply add a whitespace before the -P argument (like with tk-harmony's -debug flag)

Injection of the `-P` flag into the command to be run would only work if the `args` value was an empty string.
@aboellinger
Copy link
Author

Note that this small patch is probably irrelevant if #9 is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant