General PR Patch #138
Merged
General PR Patch #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s + load cloud fix
|
hello @eleniv3d and @DamienGilliard , if you have the time to review or at least have a look and validate the new features would be great, no major breaking changes in it anyways. Cheers! |
DamienGilliard
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Hi @9and3 , Thanks a lot for this pr. I just added 2 general remarks, both of which I can implement if you want. I still approved the PR in case we leave it like that.
Cheers !
|
@DamienGilliard thanks for the feedback, very good spot for the pickle. Just went and came back from hell and the serialization is now JSON based, I also managed to make it a bit lighter without indentation. If there isn't anything else, this is good to go to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Various fixes and new features from testing DF in the evaluation of AugmentedCarpentry experimental campaign.
new features
DFExportResults,DFImportResults,DFInspectResults: I added the serialization of the result object so that it can be saved locally under the extension.diffCheck, shared and reloaded. This was needed when evaluating multiple elements and not having the need to have a.ghfor each and re-run the results each time. This way this file can be lightweight and shared for repeatability.DFSaveCloudToPLY: simple as that.fixes
DF_cloud_cloud_distancesince it was broken but it was still included in the publicationDFCsvExportergh component distances export problem: we had a problem in exporting distances in one cell especially when exporting analysis data of large structures. In fact the limit of the csv of chars per cell is ~30k. To solve this problem, I added a separate toggle button to export distances as separate files but with id identification both in file naming and as a second column in the csv.DFCsvExportergh component as an extra crunchy perk 🥫DFLoadCloudFromFileinput checks to avoid errors + default scale value set to1.0fdocumentation