-
Notifications
You must be signed in to change notification settings - Fork 3
Feats: extract additional beam/joints data for results csv export #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s + load cloud fix
rfr @DamienGilliard / @eleniv3d in case you have a moment free. |
I'll take a look tomorrow ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through it, nothing to report 👍
df_geometries really starts to be quite rich, certainly with the "state" logic.
Thanks !
@@ -37,13 +37,14 @@ def __post_init__(self): | |||
self.__uuid = uuid.uuid4().int | |||
|
|||
def __getstate__(self): | |||
return self.__dict__ | |||
state = self.__dict__.copy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned something today :)
And tedious if you ask.. Now everytime you add a variable you need to serialize it with this state thing. But for now it is what it is. Thanks for the review! |
Description
This is a PR to integrate some useful (at least for me) features during the AC evaluation. Mainly it's about extracting extra info from the beam and joints' geometries and exporting it in the CSV/.diffCheck. Basically all the extraction of the geometric features is done in the
df_geometries.py
module and the export is a plug-in in the csv row preparation function:diffCheck/src/gh/components/DF_csv_exporter/code.py
Lines 110 to 127 in a7583ce
Important
@DamienGilliard this is not tested for round woods. I believe that everything should work with basic cylinders.
New features
DFBeam.compute_axis()
: integrated a function that properly extract the axis from the beam. It takes the two farthest joints' centroids and build the vector axis from it (a888e99)DFBeam.length
) and export it through the CSV. (8b047e6)Changes
DFExportResults
of the generated path for better debugging (b34ac88)Fixes