Various fixes for the joint detector #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f joint detector function
|
Hello @mariklad @eleniv3d @DamienGilliard , this PR is ready for review thanks! 🐦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
a new version of the joint detector: with this version various bugs are fixed from (mainly) Joint detector is failing in various scenarios #16 . We introduce a new OBB function, scale it down and detect the faces that are inside the box as joint faces. This is not tested and needs to be improved for logs (new issue joint detector needs to work for curved elements #27 ) and curved elements (new issue in joint detector needs to work for logs #28 ). With this version, all the examples in the dataset are working.
3 new components for joint detector: based on @eleniv3d 's suggestions now we pass our own
DFAssemblyobject as output and only after collapsing the assembly and the beams we can access the beam's faces/joints/ids as grafted trees. (@DamienGilliard you can use these inputs for the segmentation)XML export component refactored: the xml is now a separate component.
Here's an overview of the new joint detector/assembly/beam system, example file can be found here: