Skip to content

DF Documentation 🔖 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Aug 22, 2024
Merged

DF Documentation 🔖 #60

merged 80 commits into from
Aug 22, 2024

Conversation

9and3
Copy link
Contributor

@9and3 9and3 commented Aug 6, 2024

description

This is a PR introducing the first documentation framework for DF. It's not complete I just throw in the main structure and we will have to split the work to have a nice fully documentation for DF 😃 .
To know how to document I wrote a small guide in Further resources >> Developer documentation >> Documentation.

I liked a lot Jax ( thanks @DamienGilliard for the ref!) and I tried to replicate for us, have a look at the screenshot plis. Basically it is split in two:

  • a) Getting Started: top user (top hand) aimed to be a quickstart basically and that's our gh user,
  • b) Further resources: for developers that need extra resources.

Have a look and tell me what you think about the general structure and bare-bone content. We can maybe merge it and then split the work to do for the tutorial documentation later.

This is what it looks like:

image

image

image

Warning

I cannot show you the documentation since it has to be merged on main first before to be deployed but you can switch do this branch, upload the conda and do:

invoke documentize
start ./_build/index.html

this will build and show locally the static website.

For all the features have a look here..

main contribs/modifications

  • unecessary docstrings: I got rid of the docstrings in the Run() function for all the codee.py in the components. This function is not needed anymore since a double of the metadata (that's what we use for generating documentation)
  • component doc: I introduced a sphinx extension to automate the documentation of the components
  • py source code doc: typical py source is documented in sphinx mode. I forsee a refactoring of the pybind module that is not fully-automatically documented (marked on pybind module is not fully documented #64 ).
  • pre-commits: added precommit and linter Ruff and pymy to help us check python code sanity before committing. Before committing and in an action you will see something like this:
    image
  • better documentation: since we are going open source, it seemed good to have a better documentation on how to develop and contribute. It isn't finished but a big chunck is there and I will add the rest in a near future.

additional info

The building of the documentation and deployment is grouped in one git workflow in doc-build.yml. Only when merged to main the documentation will be deployed to the GithubPage, in all other scenarios it will only test the building of the doc.

image

@9and3 9and3 self-assigned this Aug 6, 2024
@9and3 9and3 added the documentation Improvements or additions to documentation label Aug 6, 2024
@9and3
Copy link
Contributor Author

9and3 commented Aug 19, 2024

I am missing a couple of documents to migrate from CONTRIBUTING.md but I am already opening it for review.

@9and3 9and3 marked this pull request as ready for review August 19, 2024 09:32
@eleniv3d
Copy link
Collaborator

Looks very slick to me! 👓

@9and3
Copy link
Contributor Author

9and3 commented Aug 22, 2024

Ok I am merging this one, thanks @eleniv3d @DamienGilliard for the feedback!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other remark, looks sleek indeed

@9and3 9and3 merged commit 699e67d into main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md file can use better explanation on how to contribute
3 participants