Skip to content

Simplify quantified expressions over constants #8608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Mar 24, 2025

Other simplification rules may turn the where-clause of a quantified expression into a (Boolean) constant. We can completely remove such quantified expressions so as not to distract back-ends that may special-case quantified expressions.

We saw such expressions when working on mlkem-native.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (3c915eb) to head (6a8e038).

Files with missing lines Patch % Lines
src/solvers/flattening/boolbv_quantifier.cpp 28.57% 5 Missing ⚠️
src/util/simplify_expr_boolean.cpp 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8608   +/-   ##
========================================
  Coverage    80.37%   80.37%           
========================================
  Files         1686     1686           
  Lines       206885   206928   +43     
  Branches        73       73           
========================================
+ Hits        166276   166312   +36     
- Misses       40609    40616    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kroening
Copy link
Member

It's unfortunately not that easy: The domain may be empty, and then ∀x.false is true, and ∃x.true is false.

@tautschnig
Copy link
Collaborator Author

It's unfortunately not that easy: The domain may be empty, and then ∀x.false is true, and ∃x.true is false.

Now fixed, and fixed the implementation in the propositional back-end as well.

Other simplification rules may turn the where-clause of a quantified
expression into a (Boolean) constant. We can completely remove such
quantified expressions so as not to distract back-ends that may
special-case quantified expressions.

We saw such expressions when working on mlkem-native.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants