fix npe in webhook that was accidental (#1845)

diggerhq · Nov 28, 2024 · 59caccc · 59caccc
1 parent 662bddf
commit 59caccc
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/next/controllers/github.go b/next/controllers/github.go
@@ -68,11 +68,14 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
 		if *event.Action == "deleted" {
 			err := handleInstallationDeletedEvent(event)
 			if err != nil {
-				c.String(http.StatusInternalServerError, "Failed to handle webhook event.")
+				log.Printf("Failed to handle webhook event. %v", err)
 				return
 			}
 		}
 
+		c.String(http.StatusAccepted, "ok")
+		return
+
 	case *github.IssueCommentEvent:
 		log.Printf("IssueCommentEvent, action: %v\n", *event.Action)
 	case *github.PullRequestEvent:
@@ -81,7 +84,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
 		if err != nil {
 			log.Printf("handlePullRequestEvent error: %v", err)
 		}
-		c.String(http.StatusAccepted, err.Error())
+		c.String(http.StatusAccepted, "ok")
 		return
 
 	case *github.PushEvent:
@@ -90,7 +93,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
 		if err != nil {
 			log.Printf("handlePushEvent error: %v", err)
 		}
-		c.String(http.StatusAccepted, err.Error())
+		c.String(http.StatusAccepted, "ok")
 		return
 
 	default: