fix/send corerct repo name in setstatus reporting

[motatoes]

• set correct status when sending repo in set-status endpoint
• set common logic in func

Summary by CodeRabbit

Release Notes

• Refactor

  • Simplified repository name handling in backend reporting
  • Updated method parameter names for improved clarity
  • Standardized repository name formatting in API requests

• Bug Fixes

  • Improved consistency in repository name processing across different components

The changes focus on enhancing the internal reporting mechanism with more consistent and clear repository name handling.

[coderabbitai]

Walkthrough

The pull request focuses on simplifying the repository name reporting mechanism across multiple files. Changes are primarily centered in the diggerapi.go, digger.go, and spec.go files, where the process of constructing and passing repository names for backend reporting has been streamlined. The modifications remove intermediate variables and directly use repository names or namespaces when reporting job statuses, reducing complexity in the code.

Changes

File	Change Summary
cli/pkg/digger/digger.go	Removed intermediate repoNameForBackendReporting variable, directly passing currentJob.Namespace to backend reporting
cli/pkg/spec/spec.go	Eliminated fullRepoName variable, now directly using spec.VCS.RepoName for backend reporting
libs/backendapi/diggerapi.go	Renamed repo parameter to repoFullName, added repoNameForBackendReporting to format repository name for API requests

Sequence Diagram

sequenceDiagram
    participant Client
    participant BackendAPI
    participant JobReporter

    Client->>JobReporter: Trigger Job
    JobReporter->>BackendAPI: ReportProjectJobStatus(repoFullName)
    BackendAPI->>BackendAPI: Format repoName
    BackendAPI-->>JobReporter: Job Status Response

Loading

Possibly related PRs

• always set right provider in ee #1868: Potential modifications to GitHub services method, though no direct connection to the current changes

Poem

🐰 A Rabbit's Refactoring Rhyme 🐰

In lines of code, we trim and pare,
Repository names with gentle care,
No more variables that twist and twine,
Direct and simple, our reporting's design!
Hop, hop, hooray for cleaner code today! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de0a222 and 0f9b7cf.

📒 Files selected for processing (3)

• cli/pkg/digger/digger.go (1 hunks)
• cli/pkg/spec/spec.go (1 hunks)
• libs/backendapi/diggerapi.go (3 hunks)

✅ Files skipped from review due to trivial changes (1)

• cli/pkg/spec/spec.go

🔇 Additional comments (3)

libs/backendapi/diggerapi.go (2)

133-134: LGTM! Clear and descriptive parameter name with proper repository name transformation.

The parameter rename from repo to repoFullName and the introduction of repoNameForBackendReporting improve code clarity and ensure consistent repository name formatting for backend reporting.

---

157-157: LGTM! Consistent URL path construction.

The URL path now correctly uses the transformed repository name, ensuring consistent formatting for backend reporting.

cli/pkg/digger/digger.go (1)

145-145: LGTM! Simplified repository name handling.

The code now directly passes currentJob.Namespace to the backend API, which handles the repository name transformation. This change reduces code duplication and centralizes the transformation logic in the backend API.

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.