fix env variable interpolation for backendless mode

[motatoes]

There was a bug for backendless with interpolation of environment variables which was not performed, this should fix it.

Summary by CodeRabbit

• New Features

  • Enhanced job processing and scheduling workflows have been deployed across various event triggers (push, merge, and drift events). These improvements boost consistency and reliability in task execution, helping the platform operate more smoothly and predictably.

• Style

  • Refined log formatting now provides clearer, standardized feedback during system operations, ensuring that monitoring and troubleshooting processes are more streamlined for a better overall experience.

[coderabbitai]

Walkthrough

This update modifies several modules to add an extra boolean parameter to calls of the CreateJobsForProjects function. The change is applied consistently across different controllers and services, such as in spec, drift, GitHub after merge handlers, and scheduler components. In addition, the CreateJobsForProjects function signature in the events module is updated to include this new parameter, and its internal logic has been adjusted to optionally perform environment variable interpolation. A minor formatting tweak in logging was also applied in one drift method. The overall control flow remains intact.

Changes

Files	Change Summary
ee/.../controllers/spec.go, ee/.../controllers/drift.go, next/.../controllers/github_after_merge.go, next/.../services/scheduler.go	Updated calls to CreateJobsForProjects to add an extra boolean parameter (mostly false); also adjusted logging in ProcessAllDrift.
libs/ci/generic/events.go	Updated the CreateJobsForProjects signature by adding a performEnvVarsInterpolations boolean parameter; modified internal calls (e.g., in ConvertIssueCommentEventToJobs) to pass true where environment variable interpolation is needed.

Sequence Diagram(s)

sequenceDiagram
    participant C as Controller
    participant G as CreateJobsForProjects
    participant E as EnvVar Collector
    C->>G: Call CreateJobsForProjects(..., performEnvVarsInterpolations)
    alt performEnvVarsInterpolations true
        G->>E: CollectTerraformEnvConfig(true)
    else performEnvVarsInterpolations false
        Note over G: Skip environment interpolation
    end
    G-->>C: Return jobs and possible error

Loading

Possibly related PRs

• add flag to limit by number of projects to number of changed files #1846: Related modifications to CreateJobsForProjects where a boolean parameter was added, affecting the job creation logic.

Poem

I'm a rabbit on the run,
Hopping through code under the sun,
Extra booleans now in play—
Jobs are built a brand new way,
Skipping semicolons with delight,
My whiskers twitch at each commit's light!
🐇✨

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3e523d and eb95e07.

📒 Files selected for processing (5)

• ee/backend/controllers/spec.go (1 hunks)
• ee/drift/controllers/drift.go (2 hunks)
• libs/ci/generic/events.go (4 hunks)
• next/controllers/github_after_merge.go (1 hunks)
• next/services/scheduler.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build
• GitHub Check: Build
• GitHub Check: Build

🔇 Additional comments (7)

ee/backend/controllers/spec.go (1)

57-57: LGTM!

The addition of false for performEnvVarsInterpolations is appropriate here as this is a manual spec generation that doesn't require environment variable interpolation.

libs/ci/generic/events.go (2)

132-132: LGTM!

Setting performEnvVarsInterpolations to true for issue comment events is correct as these events require full environment variable interpolation.

---

141-141: LGTM!

The changes correctly implement the control of environment variable interpolation:

1. The new parameter in the function signature provides explicit control.
2. The parameter is correctly passed to CollectTerraformEnvConfig.

Also applies to: 169-169

next/controllers/github_after_merge.go (1)

103-103: LGTM!

Setting performEnvVarsInterpolations to false for both plan and apply jobs in post-merge events is appropriate as they don't require environment variable interpolation.

Also applies to: 109-109

next/services/scheduler.go (1)

172-172: LGTM!

Setting performEnvVarsInterpolations to false for batch creation is appropriate as it doesn't require environment variable interpolation.

ee/drift/controllers/drift.go (2)

91-91: Verify the environment variable interpolation setting for drift runs.

The false parameter disables environment variable interpolation for drift runs. Please confirm this is the intended behavior, as it might affect how environment-specific configurations are handled during drift detection.

Consider documenting this behavior in the codebase to make it clear why environment variable interpolation is disabled for drift runs.

---

210-210: LGTM!

The logging statement changes maintain consistent formatting.

Also applies to: 217-217

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.