Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more geometry types #36

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Nov 26, 2024

Depends on digidem/comapeo-core#980.

In addition to Point, we now support additional geometries.

Closes #35.

@EvanHahn EvanHahn force-pushed the support-more-geometry-types branch from 64fed7d to ed23b31 Compare November 26, 2024 20:14
@rudokemper
Copy link
Member

Hey @EvanHahn sorry for this stray comment on your PR, but wanted to note that for alerts, we'll need LineString and MultiLineString as well.

With those included, you'll be covered for every possible geometry type.

@EvanHahn
Copy link
Contributor Author

Thanks for this. I don't think CoMapeo Mobile currently supports these types, so I'll ask about that.

@EvanHahn EvanHahn force-pushed the support-more-geometry-types branch from ed23b31 to 006790a Compare December 3, 2024 23:28
@EvanHahn
Copy link
Contributor Author

EvanHahn commented Dec 3, 2024

LineString and MultiLineString are now supported in this PR, which depends on them being added here, too: digidem/comapeo-geometry#17

Also requires some work to display them in CoMapeo Mobile. Issue here: digidem/comapeo-mobile#874

EvanHahn added a commit to digidem/comapeo-core that referenced this pull request Dec 11, 2024
EvanHahn added a commit to digidem/comapeo-core that referenced this pull request Dec 11, 2024
In addition to `Point`, we now support additional geometry objects.

Closes [#35].

[#35]: #35
@EvanHahn EvanHahn force-pushed the support-more-geometry-types branch from 006790a to 1847f93 Compare December 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more geometry types for alerts
2 participants