initial integration of @mapeo/core #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
force-pushed
the
mapeo-core-integration
branch
from
3718596 to
7c7a6ef
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes:
incomplete build configuration for including the necessary assets when packaging the app. we need to make sure that we keep the necessary directories/files from node_modules that are referenced by the backend. this doesn't block work in development mode, so can fix in a better-scoped follow-up (see fix build configuration for packaged app #22 )
temporarily overrides the better-sqlite version used by @mapeo/core so that it includes native prebuilds that are compatible with the version of electron that we use. think this can be fixed by upgrading @mapeo/core to alpha 11
includes a runtime patch of sodium-native due to issues it has with more recent versions of electron