Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboarding start #47

Merged
merged 4 commits into from
Nov 26, 2024
Merged

feat: onboarding start #47

merged 4 commits into from
Nov 26, 2024

Conversation

cimigree
Copy link
Contributor

@cimigree cimigree commented Nov 25, 2024 •
edited
Loading

related to #42

I didn't want to do the whole thing in one PR because I am already up to 20 files with just the first screen...

Description

  • Adds svg files.
  • Adds first onboarding screen.
  • Adds svg processor.
  • Adjusts base css.
  • Takes build files out of git.
  • Adds colors as needed.
  • Adjusts theme to match Figma designs.

Instructions

  • I think you will need to add some stuff to an env file...
VITE_ROOT_KEY
VITE_MAPBOX_ACCESS_TOKEN
ONLINE_STYLE_URL
access_token
  • Then just install everything and npm run start

Screenshots

Screenshot 2024-11-26 at 1 32 20 PM Screenshot 2024-11-26 at 1 35 28 PM Screenshot 2024-11-26 at 1 34 29 PM Screenshot 2024-11-26 at 1 33 41 PM

@cimigree
Adds svg files. Adds first onboarding screen. Adds svg processor. Adj…
8c70c5a 
…usts base css. Takes build files out of git. Adds colors as needed. Adjusts theme to match Figma designs.
@cimigree
Changes height to prevent error. Adjustments to route tree.
0a3faaf
@cimigree cimigree requested a review from EvanHahn November 25, 2024 23:24
EvanHahn
EvanHahn approved these changes Nov 26, 2024
View reviewed changes
Copy link

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had one small question but otherwise looks good.

src/renderer/src/images/LockedWithKey.svg Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These SVGs just encode PNGs when you look inside. That's fine with me, but I could see just using a PNG instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Good note! I will try to adjust them!

@cimigree cimigree merged commit 732f43d into main Nov 26, 2024
1 check passed
@cimigree cimigree deleted the feat/onboarding-start branch November 26, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cimigree @EvanHahn