-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add mapeo core react and state manager #59
Conversation
@cimigree the tests are broken, which ill fix tomorrow. I just dont want you to double the work into trying to integrate the new react hooks (not that you need them to for the invite work). But i just thought it would be good for you to see the structure of the hooks to inform your work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up! Looks like you were able to get rid of the hacky start to the app that you figured out yesterday.
There is one weird thing and it isn't related to this PR but maybe your previous one...
After I do npm install, I get a change in my package-lock.json
It shows this as deleted:
"@testing-library/user-event": "14.5.2",
This doesn't need to hold up this PR, but I wanted to mention it before I forget.
I added a bunch of things that were related but out of scope. So I decided to break up this PR into 3 smaller PRs. The code is generally the same but I just wanted to introduce things in seperate prs. Mainly because they all required a bit of configuration, and they introduced some new practices that i wanted to get more than 1 opinion on! |
There seems to be alot of touched files, but many of them are just moving files around