Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow for lockfile checks #68

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Dec 17, 2024

Copies over the workflow we've set up in core. On pull requests, it runs a job for each of the following:

  1. checking that the lockfile version doesn't change. this usually happens if someone uses an incompatible package manager version to manage dependencies, which we want to prevent

  2. highlighting changes in dependencies that the PR introduces, if any, by writing a PR comment with a table

Introducing this will be helpful for avoiding any surprise updates and highlighting intended changes moving forward

Currently, this only introduces checks on the app-level lockfile and not the backend lockfile. Probably ideal to have it check both but haven't figured out the implementation for that yet.

@achou11 achou11 requested a review from ErikSin December 17, 2024 15:51
@achou11 achou11 merged commit b5bcefc into main Dec 18, 2024
4 checks passed
@achou11 achou11 deleted the ac/lockfile-action branch December 18, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants