refactor: make core api client initialization synchronous #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, our setup for initializing the core api client in the renderer followed the approach documented in this Electron tutorial. In summary, the main process was responsible for creating the channel that connected the renderer with the "service" that runs core, which meant that the instantiation of the client in the renderer was asynchronous.
Instead, Gregor figured out an approach that allows the renderer to essentially immediately initialize the client, which makes the setup code more straightforward and also removes some complexity around asynchronous initialization. Also, based on my very minimal understanding, the immediate initialization of the client has the benefit of being able to queue messages sent by the renderer side (or maybe vice versa?) due to how MessageChannel ports work.
There are a couple of todo comments related to surfacing errors related to initialization but they shouldn't be blockers for this PR. That's something we don't have yet set up in general and can be done via a follow-up after some discussion about our general approach with errors.