Skip to content

Commit

Permalink
Remove redundant service readiness checks from deployment workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
Luisotee committed Jan 23, 2025
1 parent b56cf03 commit 6d76488
Showing 1 changed file with 0 additions and 39 deletions.
39 changes: 0 additions & 39 deletions .github/workflows/stacks.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Deployment Stacks

on:
push:
paths:
- 'deploy/**'
pull_request:
paths:
- 'deploy/**'
Expand Down Expand Up @@ -60,42 +57,6 @@ jobs:
fi
done
- name: Wait for services to be ready
run: |
while IFS= read -r dir; do
service_name=$(basename "$dir" | sed 's/-stack//')
echo "Waiting for $service_name..."
# Get port from config
port=$(bun run -b --bun ./tooling/scripts/get-port.ts ${service_name})
if [ -z "$port" ]; then
echo "No port configured for $service_name, skipping..."
continue
fi
# Wait for container health check
timeout 120 bash -c "until docker ps --filter name=${service_name} --format '{{.Status}}' | grep -q 'healthy'; do
echo 'Waiting for ${service_name} health check...'
sleep 5
done" || {
echo "Service $service_name failed to become healthy"
docker logs ${service_name}
exit 1
}
# Wait for port to be available
timeout 60 bash -c "until nc -z localhost $port; do
echo 'Waiting for port $port...'
sleep 2
done" || {
echo "Service $service_name failed to expose port $port"
docker logs ${service_name}
exit 1
}
done < $GITHUB_WORKSPACE/deploy_dirs.txt
- name: Test endpoints
run: |
while IFS= read -r dir; do
Expand Down

0 comments on commit 6d76488

Please sign in to comment.