Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Website Styling #38

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Additional Website Styling #38

merged 9 commits into from
Aug 21, 2024

Conversation

mtwente
Copy link
Contributor

@mtwente mtwente commented Aug 21, 2024

Pull request

Proposed changes

  • add a bit of css to match the other conference layout use cases
  • add darkmode settings
  • add registration information callout
  • remove breadcrumbs since there is only one level of navigation anyway that can be accessed on the navbar

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the README document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have mentioned all co-authors in the PR description as Co-authored-by: Name <[email protected]>.

Summary by CodeRabbit

  • New Features

    • Introduced a dark mode theme for improved viewing in low-light conditions.
    • Added a registration section for the DigiHistCH24 conference with a hyperlink for easy access.
  • Enhancements

    • Updated the website to support both light and dark themes with improved theme configuration.
    • Disabled breadcrumb navigation for a cleaner user experience.
    • Enhanced styling for navigation links and added hover effects for better interactivity.
  • Bug Fixes

    • Standardized navigation link colors for consistency across the application.

@mtwente mtwente requested a review from maehr August 21, 2024 07:11
Copy link
Contributor

coderabbitai bot commented Aug 21, 2024

Walkthrough

The changes encompass updates to website navigation and theming within the _quarto.yml configuration, removing breadcrumbs and implementing dual theme support for light and dark modes. The index.qmd file adds essential registration details for an upcoming conference, while the styles.css file enhances visual elements. A new theme-dark.css file provides a cohesive dark mode, improving the user interface for low-light environments.

Changes

Files Change Summary
_quarto.yml Disables breadcrumb navigation, introduces dual theme support (light & dark modes), and removes the custom CSS declaration.
index.qmd Adds a section for DigiHistCH24 conference registration, including a callout and hyperlink for readers.
styles.css Introduces new hover effects for navigation links, standardizes link colors, and adds new styles for categories and text selection.
theme-dark.css Establishes a dark mode with defined styles for navigation, code blocks, and selection colors, enhancing the interface for low-light use.

Poem

🐰 In the garden of code, changes take flight,
Breadcrumbs have vanished, new themes shine bright.
A conference beckons, with links to delight,
Styles now dance in both day and night!
With a hop and a skip, let’s embrace the new,
For in every tweak, there’s magic to view! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d2277fa and 0b7f827.

Files selected for processing (4)
  • _quarto.yml (2 hunks)
  • index.qmd (1 hunks)
  • styles.css (1 hunks)
  • theme-dark.css (1 hunks)
Additional context used
Biome
theme-dark.css

[error] 2-2: Unexpected value or character.

Expected one of:

(parse)


[error] 2-2: expected , but instead found ;

Remove ;

(parse)


[error] 3-3: Unexpected value or character.

Expected one of:

(parse)


[error] 3-3: expected , but instead found ;

Remove ;

(parse)


[error] 4-4: Unexpected value or character.

Expected one of:

(parse)


[error] 4-4: Expected an identifier but instead found '181818'.

Expected an identifier here.

(parse)


[error] 4-4: expected , but instead found ;

Remove ;

(parse)


[error] 6-6: Unexpected value or character.

Expected one of:

(parse)


[error] 6-6: Expected an identifier but instead found '4'.

Expected an identifier here.

(parse)


[error] 6-6: expected , but instead found c1a57

Remove c1a57

(parse)


[error] 6-6: expected , but instead found ;

Remove ;

(parse)


[error] 7-7: Unexpected value or character.

Expected one of:

(parse)


[error] 7-7: expected , but instead found rem

Remove rem

(parse)


[error] 7-7: Expected a compound selector but instead found '!'.

Expected a compound selector here.

(parse)


[error] 7-7: expected , but instead found default

Remove default

(parse)


[error] 7-7: expected , but instead found ;

Remove ;

(parse)


[error] 10-10: Unexpected value or character.

Expected one of:

(parse)


[error] 10-10: expected , but instead found ;

Remove ;

(parse)


[error] 11-11: Unexpected value or character.

Expected one of:

(parse)


[error] 11-11: expected , but instead found ;

Remove ;

(parse)

Additional comments not posted (5)
theme-dark.css (1)

1-16: Clarify the use of SCSS variables.

The file uses SCSS variables, which are not standard CSS. Ensure that the build process compiles SCSS to CSS correctly.

Tools
Biome

[error] 2-2: Unexpected value or character.

Expected one of:

(parse)


[error] 2-2: expected , but instead found ;

Remove ;

(parse)


[error] 3-3: Unexpected value or character.

Expected one of:

(parse)


[error] 3-3: expected , but instead found ;

Remove ;

(parse)


[error] 4-4: Unexpected value or character.

Expected one of:

(parse)


[error] 4-4: Expected an identifier but instead found '181818'.

Expected an identifier here.

(parse)


[error] 4-4: expected , but instead found ;

Remove ;

(parse)


[error] 6-6: Unexpected value or character.

Expected one of:

(parse)


[error] 6-6: Expected an identifier but instead found '4'.

Expected an identifier here.

(parse)


[error] 6-6: expected , but instead found c1a57

Remove c1a57

(parse)


[error] 6-6: expected , but instead found ;

Remove ;

(parse)


[error] 7-7: Unexpected value or character.

Expected one of:

(parse)


[error] 7-7: expected , but instead found rem

Remove rem

(parse)


[error] 7-7: Expected a compound selector but instead found '!'.

Expected a compound selector here.

(parse)


[error] 7-7: expected , but instead found default

Remove default

(parse)


[error] 7-7: expected , but instead found ;

Remove ;

(parse)


[error] 10-10: Unexpected value or character.

Expected one of:

(parse)


[error] 10-10: expected , but instead found ;

Remove ;

(parse)


[error] 11-11: Unexpected value or character.

Expected one of:

(parse)


[error] 11-11: expected , but instead found ;

Remove ;

(parse)

index.qmd (1)

25-29: LGTM! Registration callout added successfully.

The callout section for registration is a valuable addition, providing essential information and a hyperlink for attendees.

_quarto.yml (2)

14-14: LGTM! Breadcrumbs disabled.

Disabling breadcrumbs simplifies the navigation and aligns with the PR objectives.


70-72: LGTM! Dual theme support added.

The theme configuration now supports both light and dark modes, enhancing the user experience.

styles.css (1)

70-87: LGTM! Enhanced hover effects and selection styles.

The new styles improve user interaction feedback and visual consistency across the application.

Copy link
Contributor

@maehr maehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these improvements!

@maehr maehr merged commit e18937e into digihistch24:main Aug 21, 2024
3 checks passed
@mtwente mtwente deleted the styling branch August 21, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants