ci: fix ci #55
ci: fix ci #55
Conversation
WalkthroughThe change involves updating the GitHub Actions workflow configuration by modifying the operating system environment for multiple jobs and upgrading the version of the Quarto Actions used. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/quarto-publish.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/quarto-publish.yml (1)
38-38: LGTM! But verify compatibility withubuntu-20.04.The change from
ubuntu-latesttoubuntu-20.04is approved. However, ensure that all dependencies and scripts are compatible withubuntu-20.04.The code changes are approved.
Run the following script to verify the compatibility of dependencies and scripts with
ubuntu-20.04:Verification successful
Change to
ubuntu-20.04is compatible with the workflow.The actions and scripts used in the workflow are standard and should work without issues on
ubuntu-20.04. No compatibility problems were found with the current setup.
- Node.js and Python setup actions are compatible.
npmandpipcommands are standard and supported.quarto-devactions should work as expected.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of dependencies and scripts with `ubuntu-20.04`. # Test: Check for any compatibility issues in the workflow file. Expect: No issues. grep -r 'ubuntu-20.04' .github/workflows/Length of output: 104
Script:
#!/bin/bash # Description: Check for package installations and scripts in the workflow file to assess compatibility with `ubuntu-20.04`. # Search for package installations and script executions in the workflow file. grep -E 'run:|uses:' .github/workflows/quarto-publish.yml -A 2Length of output: 1646
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/quarto-publish.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/quarto-publish.yml
|
@mtwente I am out of ideas for the moment. The debugging is harder than thought... |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/quarto-publish.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/quarto-publish.yml (2)
20-20: LGTM! But verify compatibility with macOS.The change to
macos-latestfor thelintjob looks good. However, ensure that all dependencies and tools used in this job are compatible with macOS.Run the following script to verify the compatibility:
Verification successful
No macOS-specific compatibility issues found for the
lintjob.The change to
macos-latestfor thelintjob does not introduce any macOS-specific dependencies or tools that could cause compatibility issues. Ensure that the Node.js version requirement (>=v18) is satisfied in the macOS environment.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the compatibility of the `lint` job with macOS. # Test: Check for any macOS-specific dependencies or tools. rg --type yaml -A 5 $'lint'Length of output: 3352
38-38: LGTM! But verify compatibility with macOS.The change to
macos-latestfor thebuild-deployjob looks good. However, ensure that all dependencies and tools used in this job are compatible with macOS.Run the following script to verify the compatibility:
|
@mtwente I have no clue why macos works, but it does. I had to use this workaround for the metadata manual as well... Ps: perhaps the gh action needs some fine tuning to check for chromium in a better way https://github.com/quarto-dev/quarto-actions/blob/main/render/action.yml |
Pull request
Proposed changes
Types of changes
Checklist
Co-authored-by: Name <[email protected]>.Summary by CodeRabbit