-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
story/WICS-3 #36
base: develop
Are you sure you want to change the base?
story/WICS-3 #36
Conversation
…itory ConceptRepository
…s to maintain consistency with ConceptDatabaseConnection class
…tID and added a repository class for Graph
…he Service and Controller classes
…eries in GraphRepository
Can one of the admins verify this patch? |
wic/src/main/java/edu/asu/diging/wic/core/conceptpower/repository/ConceptRepository.java
Outdated
Show resolved
Hide resolved
wic/src/main/java/edu/asu/diging/wic/core/conceptpower/repository/ConceptRepository.java
Outdated
Show resolved
Hide resolved
wic/src/main/java/edu/asu/diging/wic/core/conceptpower/repository/ConceptRepository.java
Outdated
Show resolved
Hide resolved
wic/src/main/java/edu/asu/diging/wic/core/graphs/repository/GraphRepository.java
Outdated
Show resolved
Hide resolved
public Graph save(Graph graph); | ||
|
||
@Query("SELECT e FROM Edge e WHERE e.sourceNode.uri IN " | ||
+ "(SELECT alternativeUris FROM ConceptpowerAlternativeUri c WHERE c.id = :uri) " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried making this:
SELECT c.alternativeUris FROM tbl_conceptpower_concept c WHERE c.id = :uri
The way it is right now does not seem to make sense. ConceptpowerAlternativeUri
is never used is it? So the table would always be empty? I don't think you need it if you write the query correctly.
…i Entity and added EdgeRepository to fetch Alternative Edges for Edge
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]
into[x]
).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
the two left over db connection classes need to be replace with repositories
Anything else the reviewer needs to know?
... describe here ...