Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story/WICS-3 #36

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

story/WICS-3 #36

wants to merge 10 commits into from

Conversation

sri-9597
Copy link
Contributor

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

the two left over db connection classes need to be replace with repositories

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link

Can one of the admins verify this patch?

@jdamerow jdamerow closed this May 1, 2023
@sri-9597 sri-9597 reopened this May 1, 2023
public Graph save(Graph graph);

@Query("SELECT e FROM Edge e WHERE e.sourceNode.uri IN "
+ "(SELECT alternativeUris FROM ConceptpowerAlternativeUri c WHERE c.id = :uri) "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried making this:
SELECT c.alternativeUris FROM tbl_conceptpower_concept c WHERE c.id = :uri

The way it is right now does not seem to make sense. ConceptpowerAlternativeUri is never used is it? So the table would always be empty? I don't think you need it if you write the query correctly.

@jdamerow jdamerow closed this May 8, 2023
@sri-9597 sri-9597 reopened this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants