Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-9.12.1-release #575

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

shayne-fletcher
Copy link
Contributor

ghc-9.12.1 was released 2024-12-16. this PR adds official support for flavor ghc-9.12.1 (with a new test) and ghc-9.12.1 as a build compiler.

there's a temporary bit of cpp added to CI.hs and Ghclibgen.hs to support build/test with ghc-9.12.1 as a build compiler and the ormolu checks of those files is suspended.

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner December 19, 2024 02:51
Copy link

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - mostly asking questions in order to learn.

@@ -99,7 +100,7 @@ data DaFlavor = DaFlavor

-- Last tested gitlab.haskell.org/ghc/ghc.git at
current :: String
current = "caaf53881d5cc82ebff617f39ad5363429d2eccf" -- 2024-11-25
current = "bfacc086604c18e30758772a05a8c81e3a4e01bc" -- 2024-12-16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we use bfacc086604c18e30758772a05a8c81e3a4e01bc instead of https://gitlab.haskell.org/ghc/ghc/-/commit/daf659b6e3c8f2a84100fbee797cd9d457c00df5 from https://gitlab.haskell.org/ghc/ghc/-/tags/ghc-9.12.1-release ? Is it a question of what's furthest along on master?

Copy link
Contributor Author

@shayne-fletcher shayne-fletcher Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tend to put here whatever the prevailing up to the minute SHA (https://gitlab.haskell.org/ghc/ghc/-/commits/master) is on the day that i prepare the PR.

CI.hs Show resolved Hide resolved
CI.hs Show resolved Hide resolved
ghc-lib-gen/src/Ghclibgen.hs Show resolved Hide resolved
@dylant-da dylant-da merged commit 03f0dbc into digital-asset:master Dec 19, 2024
43 checks passed
@shayne-fletcher shayne-fletcher deleted the ghc-9.12.1 branch December 20, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants