Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Rules organisation #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cleanup and Rules organisation #8

wants to merge 3 commits into from

Conversation

benjaminparker
Copy link
Contributor

This should make the Rules a lot easier to manage.

Next job is to look at the Specs and see if they should also be broken down....

@adamretter
Copy link
Contributor

Ben,

Thanks very much for this work and sorry for the delay. The only issue I see is the deleting of pom.xml files in 9df85ee, we actually do want to keep the Maven build. Also I was wondering why MetaDataValidatorBusinessAcceptanceSpec.scala was removed in that same commit?

Thanks

@benjaminparker
Copy link
Contributor Author

Hi

I think I deleted the pom.xml file as I assumed that you'd be building with sbt and using publishMavenStyle which creates you a pom automatically when you do publish. If you need to build under maven then I guess you should keep the file.

The spec was removed as it references business data that wasnt commited as part of the project and therefore failed. This was used for Nicki / David's test data files as I remember.

Cheers

Ben

On 9 Sep 2013, at 15:12, Adam Retter [email protected] wrote:

Ben,

Thanks very much for this work and sorry for the delay. The only issue I see is the deleting of pom.xml files in 9df85ee, we actually do want to keep the Maven build. Also I was wondering why MetaDataValidatorBusinessAcceptanceSpec.scala was removed in that same commit?

Thanks


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants