DR2-2038 Upate Derby database #1148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now the latest version of derby. This version needs Java 21. I've updated the bundled version to use 21. The name of the driver class has changed and has been updated in all of the places it's set. I wanted to get this working on 21 anyway. DROID itself runs happily on 21 but the tests weren't passing because of how old Mockito was so I've upgraded that. I've removed versions 7 and 11 and 17 from the CI workflow. I've updated the ci workflow to use an NVD API key which is set in the repository secrets to stop the ci run taking an hour periodically. I've removed the supressions for the old version of the derby DB The last thing was an odd test failure in the tests for ProfileFileChooser It was saying that multiSelectionEnabled was true when run on Java 21. If you run DROID on Java 21 then multi selection is enabled. I'm not sure why but setting it to false in the setup method brings back the old behaviour.
MancunianSam
force-pushed
the
DR2-2038-upgrade-derby-database
branch
from
a5f8425 to
c922787
Compare
techncl
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now the latest version of derby.
This version needs Java 21. I've updated the bundled version to use 21.
The name of the driver class has changed and has been updated in all of
the places it's set.
I wanted to get this working on 21 anyway. DROID itself runs happily on
21 but the tests weren't passing because of how old Mockito was so I've
upgraded that.
I've removed versions 7 and 11 and 17 from the CI workflow.
I've updated the ci workflow to use an NVD API key which is set in the
repository secrets to stop the ci run taking an hour periodically.
I've removed the supressions for the old version of the derby DB
The last thing was an odd test failure in the tests for ProfileFileChooser
It was saying that multiSelectionEnabled was true when run on Java 21.
If you run DROID on Java 21 then multi selection is enabled. I'm not
sure why but setting it to false in the setup method brings back the old
behaviour.