2438: Fix tests

digitalfabrik · Sep 30, 2023 · 39b9974 · 39b9974
1 parent 10f8e7d
commit 39b9974
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 17 deletions.
diff --git a/native/jest.setup.ts b/native/jest.setup.ts
@@ -10,6 +10,7 @@ global.fetch = require('jest-fetch-mock')
 console.error = () => undefined
 
 jest.mock('@react-native-async-storage/async-storage', () => mockAsyncStorage)
+jest.mock('react-native-permissions', () => require('react-native-permissions/mock'))
 
 // react-navigation jest setup
 // https://reactnavigation.org/docs/testing#mocking-native-modules

diff --git a/native/src/__tests__/Navigator.spec.tsx b/native/src/__tests__/Navigator.spec.tsx
@@ -122,6 +122,7 @@ jest.mock('../utils/PushNotificationsManager', () => ({
   pushNotificationsSupported: jest.fn(() => true),
   quitAppStatePushNotificationListener: jest.fn(),
   useForegroundPushNotificationListener: jest.fn(),
+  androidPushNotificationPermissionFix: jest.fn(async () => undefined),
 }))
 jest.mock('../utils/FetcherModule')
 

diff --git a/native/src/components/__tests__/NearbyCities.spec.tsx b/native/src/components/__tests__/NearbyCities.spec.tsx
@@ -15,7 +15,6 @@ jest.mock('../../utils/LocationPermissionManager', () => ({
   checkLocationPermission: jest.fn(),
   requestLocationPermission: jest.fn(),
 }))
-jest.mock('react-native-permissions', () => require('react-native-permissions/mock'))
 jest.mock('@react-native-community/geolocation')
 jest.mock('react-i18next')
 

diff --git a/native/src/utils/__tests__/PushNotificationsManager.spec.ts b/native/src/utils/__tests__/PushNotificationsManager.spec.ts
@@ -1,8 +1,10 @@
 import AsyncStorage from '@react-native-async-storage/async-storage'
 import messaging, { FirebaseMessagingTypes } from '@react-native-firebase/messaging'
 import { mocked } from 'jest-mock'
+import { requestNotifications } from 'react-native-permissions'
 
 import buildConfig from '../../constants/buildConfig'
+import appSettings from '../AppSettings'
 import * as PushNotificationsManager from '../PushNotificationsManager'
 
 jest.mock('@react-native-firebase/messaging', () => jest.fn(() => ({})))
@@ -72,30 +74,20 @@ describe('PushNotificationsManager', () => {
       expect(mockRequestPermission).not.toHaveBeenCalled()
     })
 
-    it('should request permissions and return false if not granted', async () => {
+    it('should request permissions and return false and disable push notifications in settings if not granted', async () => {
       mockBuildConfig(true, false)
-      const mockRequestPermission = jest.fn(async () => 0)
-      mockedFirebaseMessaging.mockImplementation(() => {
-        const previous = previousFirebaseMessaging
-        previous.requestPermission = mockRequestPermission
-        return previous
-      })
+      mocked(requestNotifications).mockImplementationOnce(async () => ({ status: 'blocked', settings: {} }))
 
       expect(await PushNotificationsManager.requestPushNotificationPermission()).toBeFalsy()
-      expect(mockRequestPermission).toHaveBeenCalledTimes(1)
+      expect((await appSettings.loadSettings()).allowPushNotifications).toBe(false)
     })
 
     it('should request permissions and return true if granted', async () => {
       mockBuildConfig(true, false)
-      const mockRequestPermission = jest.fn(async () => 1)
-      mockedFirebaseMessaging.mockImplementation(() => {
-        const previous = previousFirebaseMessaging
-        previous.requestPermission = mockRequestPermission
-        return previous
-      })
+      mocked(requestNotifications).mockImplementationOnce(async () => ({ status: 'granted', settings: {} }))
 
       expect(await PushNotificationsManager.requestPushNotificationPermission()).toBeTruthy()
-      expect(mockRequestPermission).toHaveBeenCalledTimes(1)
+      expect((await appSettings.loadSettings()).allowPushNotifications).toBe(true)
     })
   })
 

diff --git a/native/src/utils/__tests__/createSettingsSections.spec.ts b/native/src/utils/__tests__/createSettingsSections.spec.ts
@@ -24,7 +24,6 @@ jest.mock('../../utils/PushNotificationsManager', () => ({
   subscribeNews: jest.fn(),
   unsubscribeNews: jest.fn(),
 }))
-jest.mock('react-native-permissions', () => require('react-native-permissions/mock'))
 jest.mock('@react-native-community/geolocation')
 
 const mockRequestPushNotificationPermission = mocked(requestPushNotificationPermission)