2321: Added minimum space between navigation tiles and toolbar #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relentless95
requested review from
steffenkleinle,
sarahsporck,
ztefanie,
f1sh1918 and
LeandraH
as code owners
LeandraH
reviewed
Oct 2, 2023
|
i think so, but i am not sure where the merge conflict is. can you point it out? |
|
It's a conflict between the two versions of |
LeandraH
reviewed
Oct 2, 2023
LeandraH
approved these changes
Oct 18, 2023
steffenkleinle
requested changes
Oct 18, 2023
relentless95
force-pushed
the
2321-minimum-space-btw-navtiles
branch
from
6009f65
to
db27e53
Compare
LeandraH
approved these changes
Dec 7, 2023
steffenkleinle
approved these changes
Dec 8, 2023
|
@relentless95 can you run prettier once? Seems like some formatting is still of in Layout.tsx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
there is almost no space between navigation tiles and toolbar when there are only a few languages available for a city.
Proposed changes
Created the variable additionalWidth (35px) in dimensions.tsx to be used inside the styled.aside element found in Layout.tsx to increase the distance between the navigation tiles and toolbar.
Side effects
None
Resolved issues
Fixes: #2321