-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2031: Combine recurring events native #2495
2031: Combine recurring events native #2495
Conversation
b107346
to
8fc97c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i open events on ios, they are not combined @steffenkleinle
This relies probably on local data i think they were not refetched properly after updating the app. When i delete the app and reinstall it everything works.
Maybe there is some additional cache invalidation needed to get this work
Additionally i think same issues than web. Start and end times are not correct and on smaller devices like iPhone SE it won't fit on a single page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed, database should be invalidated on update.
Using 'D' format for numeric months as well, start and end times should be fixed with #2506. |
Hm ok looks like you decided not to use short month format @steffenkleinle ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ios
You would rather want abbreviated months you mean? Like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android, works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I don't mind the months being shown as numbers instead of short names, I think both are pretty clear since the structure follows the conventions for the phone language.
Edit: tested on emulated iOS
fcfa8c0
into
2031-combine-recurring-events-web
Short description
This PR combines recurring events such that they only show up once in the list.
Proposed changes
Side effects
None.
Resolved issues
Fixes #2031.