2404: Convert tools to ESM #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsporck
requested review from
steffenkleinle,
ztefanie,
f1sh1918 and
LeandraH
as code owners
Open
Open
Open
|
Do you have extensions that do the updated importing automatically for us? I foresee a lot of wrong imports in the future... |
steffenkleinle
approved these changes
Oct 9, 2023
I added a eslint-plugin that checks that. Also, if you have set "type": "module" in the package.json this should done automatically by your IDE |
LeandraH
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR displays in a small scope how the conversion to esm could look like. Feel free to ask questions and make remarks if you are unhappy.
Proposed changes
Resolved issues
Partially addresses: #2404