Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2808: Add a filter by date option to events #2898
base: main
Are you sure you want to change the base?
2808: Add a filter by date option to events #2898
Changes from 38 commits
5028027
b6683da
8dd13b4
3fb9deb
566da43
3c0dbe5
63d158a
4df2415
c67fd25
60f9de7
193909c
e701023
5d18825
c1cab6d
25406e8
3321eb4
115de27
e652e78
000a9a4
d7ca0ff
a6176f5
5b10e03
52db677
8929238
915c099
a371455
df9e206
075d88a
87f7daa
8ea2492
ab81a63
d537677
2af2efa
2464cc5
a19bb07
4232588
f62a0ca
dc2a79f
aeceee3
1f1ca05
ac24b22
20fd593
829c7b2
b3ba08b
4282d93
abb3d98
4990e93
2085834
ca5a9bf
0346272
c63fd9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ The height can go directly into the
StyledTextButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I tried that.. its common sense to put it in
StyledTextButton
but that didn't work..😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird, it worked when I tested it, only the font size needed to be added in-line 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Why are you setting these temporary values as you're closing the modal? Wouldn't they be filled in correctly anyway with the next opening?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Canceling means putting back old values for calendarModal. When you open the modal again it should show what being selected at inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But those are props that are handed in when opening the modal. Have you tested if it works without this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I test it without ... If I selected a date and pressed cancel and opened the calendar again it will show the same date I selected before canceling. so I think these are needed to get the previous value back
Check warning on line 124 in native/src/components/CalendarRangeModal.tsx
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
Check warning on line 145 in native/src/components/CalendarRangeModal.tsx
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method