Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up local development android builds #2973

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle steffenkleinle commented Oct 25, 2024

Short description

Speed up local development android builds using --active-arch-only flag.
See https://reactnative.dev/docs/build-speed#build-only-one-abi-during-development-android-only.

Testing

Android build still works.

Resolved issues

Fixes: None.


Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit 73547c6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.1%.

View more on Code Climate.

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome, great find! Not tested though 😅

Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement 🚀

Tested on an emulated andoid (ABI x86_64). ABI was detected properly and build successfully in 3m 4s

Just one small comment.

native/run Outdated Show resolved Hide resolved
@steffenkleinle steffenkleinle merged commit 1c32e64 into main Nov 11, 2024
9 checks passed
@steffenkleinle steffenkleinle deleted the speed-up-android branch November 11, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants