-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2468: Reordered header icons in web #2993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats to your first PR! 🎉 Works as expected, tested on firefox. Could you perhaps add a release note for this? Thank you :)
https://github.com/digitalfabrik/integreat-app/blob/main/docs/contributing.md#release-notes
Thank you! I now added a release note :) I assumed "show_in_stores" should be true, but I wasn't sure there 😅 |
That is okay! The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on firefox and android 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Tested in Firefox
@janichla Nice, you now have enough approvals to merge the PR! You can click on "Update branch" to merge main into your branch to get it to the latest state, and then merge the PR. Congratulations! |
Short description
Reorder header icons.
Only did it in web, because Steffen told me to focus on web since I'm just getting started.
Proposed changes
Side effects
Testing
Resolved issues
Fixes: #2468