Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2468: Reordered header icons in web #2993

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

janichla
Copy link
Contributor

Short description

Reorder header icons.
Only did it in web, because Steffen told me to focus on web since I'm just getting started.

Proposed changes

  • adjusted order of header icons in CityContentHeader.tsx

Side effects

  • none.

Testing

  • local testing.

Resolved issues

Fixes: #2468


Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats to your first PR! 🎉 Works as expected, tested on firefox. Could you perhaps add a release note for this? Thank you :)
https://github.com/digitalfabrik/integreat-app/blob/main/docs/contributing.md#release-notes

@janichla
Copy link
Contributor Author

Thank you! I now added a release note :) I assumed "show_in_stores" should be true, but I wasn't sure there 😅

@steffenkleinle
Copy link
Member

Thank you! I now added a release note :) I assumed "show_in_stores" should be true, but I wasn't sure there 😅

That is okay! The show_in_stores is only relevant for release notes with android or ios platforms. In general, most user facing changes should be shown in the store release notes. So it was a good choice in any case 👍

Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on firefox and android 🚀

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Tested in Firefox

@LeandraH
Copy link
Contributor

@janichla Nice, you now have enough approvals to merge the PR! You can click on "Update branch" to merge main into your branch to get it to the latest state, and then merge the PR. Congratulations!

@janichla janichla merged commit 8e2e483 into main Nov 29, 2024
9 checks passed
@janichla janichla deleted the 2468-reorder-the-icons-in-the-header branch November 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder the icons in the header
3 participants