3029: Add typing indicator for automatic replies in chat #3056
Conversation
lunars97
requested review from
steffenkleinle,
f1sh1918,
LeandraH and
bahaaTuffaha
as code owners
lunars97
force-pushed
the
3029-add-typing-indicator-for-automatic-replies
branch
from
50de658 to
2a08823
Compare
lunars97
force-pushed
the
3029-add-typing-indicator-for-automatic-replies
branch
from
2a08823 to
529d718
Compare
lunars97
changed the title
|
The typing indicator also appearing before the automatic reply, I have no idea how to limit this behaviour... Any ideas? |
| @@ -41,6 +54,19 @@ const ChatConversation = ({ messages, hasError, className }: ChatConversationPro | |||
| } | |||
| }, [messages, messagesCount]) | |||
|
|
|||
| // eslint-disable-next-line consistent-return | |||
| useEffect(() => { | |||
| if (!lastMessage?.userIsAuthor && lastMessage?.isAutomaticAnswer) { | |||
There was a problem hiding this comment.
Hmm, I am not really sure abot that condition... shouldn't the typing indicator basically be displayed 60s after the user sends a message? i.e. shouldn't this be
| if (!lastMessage?.userIsAuthor && lastMessage?.isAutomaticAnswer) { | |
| if (lastMessage?.userIsAuthor) { |
There was a problem hiding this comment.
It was not working with lastMessage because lastMessage is automatic answer, as Sven noted that we should show it only after the automatic answer, but the problem is that we have only two parameters userIsAuthor and automaticAnswer, we do not have properties for chatbot and for real person to limit it...
There was a problem hiding this comment.
I misunderstood Svens message, sorry. You implemented it perfectly! See here for clarification: #3029 (comment)
Since you exactly implemented it like this, nothing to do here anymore :)
|
Also see my question here: #3029 (comment) |
Short description
Typing indicator message (...) for 60 seconds should be shown after automatic answer in chat. It will be a temporary solution untill the websocket implementation
Proposed changes
Side effects
Resolved issues
Fixes: #3029