-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inherits
for Schema.sql
#1998
Draft
amitaibu
wants to merge
66
commits into
master
Choose a base branch
from
core-inherits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
2431d6a
Implement `inherits` for Schema.sql
amitaibu 9bee88c
Adapt `compileStatement`
amitaibu 2b71e5e
Add tests
amitaibu c1844ac
Fix missing field
amitaibu 0578ae1
Try to fix Running the development server
amitaibu bd1220d
Test fixes
amitaibu dc248f7
Adjust docs
amitaibu 480d8f3
Another missing field
amitaibu 70dadc5
Merge branch 'master' into core-inherits
amitaibu 3b9df34
More test fixes
amitaibu 518811a
More test fixes
amitaibu 70c7e71
More fixes
amitaibu 19c80b3
CompilerSpec fixes
amitaibu ec978c9
Fix typo
amitaibu 1fd95fe
Fix tests
amitaibu 591c40f
Replace space in compilerSpec
amitaibu cbea5de
Another fix
amitaibu 53e7085
Update SchemaCompiler
amitaibu d8e7f28
Update docs
amitaibu bebd467
Revert "Added inline annotations for getQueryBuilder"
amitaibu 765a969
Fix wrong comma when no parent table
amitaibu 389df33
Remove duplicate MetaBag
amitaibu 6abdbf1
Add comment
amitaibu 83f652e
Try fix typeArguments
amitaibu c0ec985
Add todo
amitaibu 1a0dc74
Fix docs typo
amitaibu b095996
Try to filter wrong vars
amitaibu d8c6662
filter out the ID
amitaibu 48a3bda
Apply columnNames
amitaibu 97047b0
compileTypePattern
amitaibu 339374b
fix columnNames
amitaibu 781417c
Add comment
amitaibu 8f38d7a
Fix compileTypeAlias
amitaibu cb3a7d2
compileHasTableNameInstance
amitaibu 22d71b0
compileUpdateFieldInstances
amitaibu 29395ae
compileGetModelName
amitaibu 1d046db
compileUpdateFieldInstances
amitaibu 354208d
More careful compileUpdateFieldInstances
amitaibu bd2f544
compileDataTypePattern
amitaibu 05fe2f2
Remove `meta` from compileUpdateFieldInstances
amitaibu 2dc6e5d
Place the `meta` as the last value.
amitaibu b4d0001
Fix meta
amitaibu 78da6fa
more work
amitaibu 8ea918b
More consistent code
amitaibu 97ede64
More Set and Update
amitaibu 351f5b2
Adapt compileBuild
amitaibu b93791d
More fixes to compileBuild
amitaibu 613bb0d
Add todo question
amitaibu 27897e9
Revamp compileFromRowInstance
amitaibu f70d902
Fix compileInclude
amitaibu 5a11fd3
Allow set parent fields
amitaibu fa31d5b
compileCreate
amitaibu 95ea731
compileUpdate
amitaibu 2d1601d
Start adding inherits info to renderColumnSelector
amitaibu b59e405
Show inherits on UI
amitaibu 9d9c02c
Add padding
amitaibu 9b9e976
Fix tests
amitaibu d4d20c3
Add comment
amitaibu a231a50
Add docs
amitaibu 57621fa
Start adding tests
amitaibu a213547
Note on Constraints in Inherited Tables
amitaibu c957833
minor typo
amitaibu 2ce5f4f
Remove duplicated func
amitaibu c727968
Revert "minor typo"
amitaibu c180627
Fix typo
amitaibu f2d002a
more readable code
amitaibu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpscholten I think the doc is outdated.
make console
, mentioned above , needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could just be
ghci
.make console
is just an alias forghci
.Can you try
:set -iIHP/ihp-ide
in the ghci? This will add theIHP/ihp-ide
directory to the load path. After that it should load without the error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it helped (adapted docs)
But now I get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce that. Just tried it locally and here's an approach how I got it working with latest IHP:
That should work now
locally i run into a ghc bug while doing that, I hope it works for you:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a workaround for the GHC bug I reverted the commit that introduced the bug by running
git revert 4fe8b56e5a8c5dcb394a16b0dfb5eb2d6f77b18f
from within theIHP
directoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've ran into more issues with the dev server right now and added a new helper called
mainInParentDirectory
to fix that.After you've synced this branch with latest master it should now work like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into it 🙏
I'm confused about which URL should be in my
flake.nix
ihp/CONTRIBUTING.md
Lines 43 to 67 in 27a696a
I'm guessing we should always tell folks to point to the local IHP, or is there a different use case?