Skip to content

Commit

Permalink
update image_category_wall as screenshot datasource does not have cat…
Browse files Browse the repository at this point in the history
…egory column; this is not ideal and ought to be solved in another way.

Also, could I get categories from the metadata? That's... ugh.
  • Loading branch information
dale-wahl committed Sep 14, 2023
1 parent 392c633 commit 13a6e8b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion backend/lib/selenium_scraper.py
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ def search(self, query):
self.start_selenium(eager=(hasattr(self, "eager_selenium") and self.eager_selenium))
# Returns to default position; i.e., 'data:,'
self.reset_current_page()
# Sets timeout to 60
# Sets timeout to 60; can be updated later if desired
self.set_page_load_timeout()

# Normal Search function to be used To be implemented by descending classes!
Expand Down
3 changes: 2 additions & 1 deletion processors/visualisation/image_category_wall.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ def is_compatible_with(cls, module=None, user=None):
:param module: Dataset or processor to determine compatibility with
"""
return module.type.startswith("image-to-categories") or module.type.startswith("image-downloader")
# TODO: cannot run on image-downloader-screenshots-search as it does not have a category column!
return module.type.startswith("image-to-categories") or (module.type.startswith("image-downloader") and not module.type not in ["image-downloader-screenshots-search"])

@classmethod
def get_options(cls, parent_dataset=None, user=None):
Expand Down

0 comments on commit 13a6e8b

Please sign in to comment.