Always unlink zip file after handling

digitalmethodsinitiative · Nov 13, 2024 · f403d8b · f403d8b
1 parent 59f3835
commit f403d8b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/backend/workers/manage_extension.py b/backend/workers/manage_extension.py
@@ -190,9 +190,10 @@ def unpack_from_zip(self, archive_path):
             with zipfile.ZipFile(archive_path, "r") as archive_file:
                 archive_file.extractall(temp_name)
         except Exception as e:
-            archive_path.unlink()
             return self.extension_log.error(f"Could not extract extension zip archive {archive_path.name}: {e}. Cannot "
                                             f"install."), None
+        finally:
+            archive_path.unlink()
 
         return temp_name, extension_name