Added Selenium URL scraper as new datasource; modified column filter to allow detailed matching information #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and webdriver afterwards
stijn-uva
requested changes
Dec 2, 2021
after_process only runs when process completes successfully
these are more likely due to an issue with the website in question
this is by individual worker class not for all selenium classes... so you can really crank them out if desired
…itiative/4cat into tracker_tracker
…ot properly closing
# Conflicts: # backend/lib/search.py # common/lib/helpers.py # common/lib/module_loader.py # processors/visualisation/download_videos.py # processors/visualisation/image_category_wall.py # processors/visualisation/video_hasher.py # setup.py
|
Closing; this will be obsolete with the extensions PR and all updates, datasources, and processors have been moved to a new repository. I will remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selenium_scraperas a new Search class to be used in creating new datasources.url_scraperdatasource which allows a user to scrape a list of urls and up to 5 subpages on the hostcolumn-filterprocessor to provide detail output showing which matches were found in a given column (this can mimic Tracker Tracker by searching for substrings within HTML and noting which were found/not found in the HTML)after_search_completedmethod; this was necessary to ensure Selenium webdriver and Chrome browser are properly closed and also works withget_itemsgenerators.validate_urlhelper function added tohelpers.py@stijn-uva I have tested this and not found any issues, but did want you to particularly review the changes to Search.