This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Phrases must not exceed 60chrs each#335

Merged

niczem merged 17 commits intodigitalmethodsinitiative:developfrom xmacex:phrases_must_not_exceed_60chrs_each

Jul 8, 2020

+42-3

Commits on Oct 1, 2018

First fortifications against phrases ¨longer than 60 characters in a new bin, both at the web UI and further down the stack.
xmacex
committed

Commits on Oct 2, 2018

Explode out the phrases into a variable before inspecting their lengths
xmacex
committed
Added a small test suite, which now also relies on the create_new_bin to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not…
xmacex
committed
Added a small test suite, which now also relies on the create_new_bin to throw an exception in addition to an error message for humans. This is a risky move up the stack I might think, if it is not…
xmacex
committed
Merge branch 'phrases_must_not_exceed_60chrs_each' of https://github.com/xmacex/dmi-tcat into phrases_must_not_exceed_60chrs_each
xmacex
committed
Fixed a minor typo of a test data set name. I'll be honest, this is a procrastination commit under cognitive stress of getting all the tests in place. Please bear with me.
xmacex
committed
Added checks against long query phrases to the query modification functionality in modify_bin() too. On the UI side the same validateQuery() is used as when making a new bin, so I that should be fine.
xmacex
committed

Commits on Nov 10, 2018

Commits on Nov 13, 2018

Commits on Feb 23, 2020

Merge branch 'master' into phrases_must_not_exceed_60chrs_each
niczem
authored