Fix probable bugs when unhandled errors (#1056)

Co-authored-by: Andrew Starr-Bochicchio <[email protected]>

commands/droplets.go

@@ -318,9 +318,8 @@ func RunDropletCreate(c *CmdConfig) error {
 			return err
 		}
 	}
-	c.Display(item)
 
-	return nil
+	return c.Display(item)
 }
 
 // RunDropletTag adds a tag to a droplet.

commands/firewalls.go

@@ -415,7 +415,10 @@ func extractInboundRules(s string) (rules []godo.InboundRule, err error) {
 		}
 		mr, _ := json.Marshal(rule)
 		ir := &godo.InboundRule{}
-		json.Unmarshal(mr, ir)
+		err = json.Unmarshal(mr, ir)
+		if err != nil {
+			return nil, err
+		}
 		rules = append(rules, *ir)
 	}
 
@@ -435,7 +438,10 @@ func extractOutboundRules(s string) (rules []godo.OutboundRule, err error) {
 		}
 		mr, _ := json.Marshal(rule)
 		or := &godo.OutboundRule{}
-		json.Unmarshal(mr, or)
+		err = json.Unmarshal(mr, or)
+		if err != nil {
+			return nil, err
+		}
 		rules = append(rules, *or)
 	}
 

commands/registry.go

@@ -386,7 +386,10 @@ func RunRegistryLogin(c *CmdConfig) error {
 			return err
 		}
 
-		cf.Save()
+		err = cf.Save()
+		if err != nil {
+			return err
+		}
 	}
 
 	return nil

scripts/gen-yaml-docs.go

@@ -65,7 +65,10 @@ func writeDocs(cmd *cobra.Command, dir string) error {
 	defer f.Close()
 
 	// Call Cobra's GenYaml command, passing in the created file
-	doc.GenYaml(cmd, f)
+	err = doc.GenYaml(cmd, f)
+	if err != nil {
+		return err
+	}
 	// Append alias information to the standard YAML output
 	aliases := fmt.Sprintf("aliases: %s\n", strings.Join(cmd.Aliases, ", "))