Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[droplets]: add droplet backup policies #749

Merged
merged 16 commits into from
Nov 5, 2024
Merged

[droplets]: add droplet backup policies #749

merged 16 commits into from
Nov 5, 2024

Conversation

loosla
Copy link
Contributor

@loosla loosla commented Oct 28, 2024 •
edited
Loading

This PR adds droplet backup policies:

  • get droplet backup policy
  • list all droplet backup policies
  • list supported droplet backup policies

@loosla loosla marked this pull request as ready for review October 29, 2024 14:16
@loosla loosla requested a review from a team October 29, 2024 14:16
andrewsomething
andrewsomething requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline with suggestions from my first pass reviewing this.

droplets.go Outdated Show resolved Hide resolved
droplets.go Outdated Show resolved Hide resolved
droplets.go Outdated Show resolved Hide resolved
droplets.go Outdated Show resolved Hide resolved
droplets.go Outdated Show resolved Hide resolved
@loosla loosla marked this pull request as draft November 1, 2024 18:44
@loosla
remove omitempty for backup policy hour in DropletBackupPolicyRequest…
e886602 
… to be able to use zero as a value when encoding in client.NewRequest
@loosla
Copy link
Contributor Author

loosla commented Nov 4, 2024

As godo is a thin layer and EnableBackupsWithPolicy is not changing backups, but only changing backup_policy, we may consider renaming of EnableBackupsWithPolicy.

@loosla loosla marked this pull request as ready for review November 4, 2024 17:33
@loosla loosla requested a review from a team November 4, 2024 17:33
andrewsomething
andrewsomething reviewed Nov 4, 2024
View reviewed changes
droplet_actions.go Outdated Show resolved Hide resolved
droplet_actions.go Outdated Show resolved Hide resolved
droplets.go Outdated Show resolved Hide resolved
loosla and others added 2 commits November 4, 2024 16:44
@loosla @andrewsomething
Update droplet_actions.go
ecaa7bd 
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
@loosla
add ChangeBackupPolicy; use DropletBackupPolicyRequest instead of map…
a379869 
… in request; update and add tests for changes made
@loosla
Copy link
Contributor Author

loosla commented Nov 5, 2024

@andrewsomething TF PR is updated with the changes made after the review on Nov 4, 2024

andrewsomething
andrewsomething approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@loosla loosla merged commit a11b76f into main Nov 5, 2024
8 checks passed
@loosla loosla deleted the alushnikova/add-droplet-backup-policies branch November 5, 2024 22:06
@andrewsomething andrewsomething mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loosla @andrewsomething