-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing Database Configs for Postgresql and MYSQL #755
Merged
loosla
merged 4 commits into
digitalocean:main
from
vsharma6855:feature/add-database-config
Nov 13, 2024
Merged
Add Missing Database Configs for Postgresql and MYSQL #755
loosla
merged 4 commits into
digitalocean:main
from
vsharma6855:feature/add-database-config
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsharma6855
changed the title
Added Missing Database Configs for Postgresql and MYSQL
Add Missing Database Configs for Postgresql and MYSQL
Nov 11, 2024
loosla
reviewed
Nov 12, 2024
loosla
reviewed
Nov 12, 2024
Co-authored-by: Anna Lushnikova <[email protected]>
Sure 😃
…On Tue, Nov 12, 2024, 10:11 PM Anna Lushnikova ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In databases.go
<#755 (comment)>:
> @@ -653,6 +656,13 @@ type MySQLConfig struct {
BackupHour *int `json:"backup_hour,omitempty"`
BackupMinute *int `json:"backup_minute,omitempty"`
BinlogRetentionPeriod *int `json:"binlog_retention_period,omitempty"`
+ InnodbChangeBufferMaxSize *uint32 `json:"innodb_change_buffer_max_size,omitempty"`
Using int as the type in godo will make it easier to handle these fields
in Terraform.
int is more manageable in the long run since Terraform doesn't support
uint64. Without this change, we'd need to perform additional steps to
convert the value from a string to uint64 in Terraform.
It's simpler to add a validation in Terraform (e.g.,
validation.IntAtLeast(0)) to ensure the min which is not always a zero, but
can be 1 or 1024 (net_buffer_length).
There will be more clarity to keep these fields as numeric rather than
strings in Terraform.
Vikas, could you please update data type to *int for
- InnodbFlushNeighbors
- InnodbReadIoThreads
- InnodbThreadConcurrency
- InnodbWriteIoThreads
- NetBufferLength
too 🙏 ?
—
Reply to this email directly, view it on GitHub
<#755 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKL5O466KSSADOT3CWARFTD2AIVUZAVCNFSM6AAAAABRR5OHB6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZQGE2DKNBQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
loosla
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me.
Thank you 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of
https://do-internal.atlassian.net/browse/DBAAS-5519
https://do-internal.atlassian.net/browse/DBAAS-5587
We need to add missing
postgresql
andmysql
database configs to godo.