Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reserved ipv6 changes as Beta #759

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

imaskm
Copy link
Contributor

@imaskm imaskm commented Nov 20, 2024

This PR adds the support for ReserveIPv6 to the godo package

Copy link

gitguardian bot commented Nov 20, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9440723 Triggered PostgreSQL Credentials 50e124a databases_test.go View secret
9440723 Triggered PostgreSQL Credentials 50e124a databases_test.go View secret
9440724 Triggered PostgreSQL Credentials 50e124a databases_test.go View secret
9440724 Triggered PostgreSQL Credentials 50e124a databases_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

reserved_ipv6.go Outdated Show resolved Hide resolved
reserved_ipv6.go Outdated Show resolved Hide resolved
reserved_ipv6.go Outdated Show resolved Hide resolved
reserved_ipv6.go Outdated Show resolved Hide resolved
godo.go Outdated Show resolved Hide resolved
@imaskm imaskm changed the title Add reserved ipv6 changes Add reserved ipv6 changes as Beta Nov 21, 2024
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@andrewsomething andrewsomething merged commit 73ff37f into digitalocean:main Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants